From 53ff89dacc94b04365b646b9ba297206b211a4a7 Mon Sep 17 00:00:00 2001
From: dechert <dechert@atb-bremen.de>
Date: Fri, 17 Jan 2025 19:48:14 +0100
Subject: [PATCH] refactor script

---
 rsync-cron/run_tmbackup.sh | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/rsync-cron/run_tmbackup.sh b/rsync-cron/run_tmbackup.sh
index ee7db20..c7a053d 100644
--- a/rsync-cron/run_tmbackup.sh
+++ b/rsync-cron/run_tmbackup.sh
@@ -1,19 +1,24 @@
 #!/bin/bash
 
+readonly TARGET_MOUNTED_DRIVE="/volumeUSB1"
+readonly SCRIPT_PATH="/volume2/homes/admin/marceload_backup/rsync_tmbackup.sh"
+readonly SOURCE_DIR="/volume2/homes/admin/marceload_backup/test-folder"
+readonly BACKUP_DIR="/volume2/homes/admin/marceload_backup/backup-folder"
+
 # Check if /volumeUSB1 is mounted
-if grep -qs "/volumeUSB1" /proc/mounts; then
+if grep -qs "${TARGET_MOUNTED_DRIVE}" /proc/mounts; then
   echo "/volumeUSB1 is mounted. Starting backup..."
 
   # Ensure the backup script exists
-  if [ -x "/volume2/homes/admin/marceload_backup/rsync_tmbackup.sh" ]; then
+  if [ -x "${SCRIPT_PATH}" ]; then
     # Run the backup script
-    /volume2/homes/admin/marceload_backup/rsync_tmbackup.sh /volume2/homes/admin/marceload_backup/test-folder /volume2/homes/admin/marceload_backup/backup-folder
+    "${SCRIPT_PATH}" "${SOURCE_DIR}" "${BACKUP_DIR}"
     echo "Backup completed successfully."
   else
-    echo "Error: Backup script not found or not executable: /volume2/homes/backup/rsync_tmbackup.sh"
+    echo "Error: Backup script not found or not executable: ${SCRIPT_PATH}"
     exit 1
   fi
 else
-  echo "/volumeUSB1 is not mounted. Skipping backup."
+  echo "${TARGET_MOUNTED_DRIVE} is not mounted. Skipping backup."
   exit 1
 fi